Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-948463 Removed error information for PUT command for GCP #801

Merged
merged 1 commit into from
Oct 27, 2023
Merged

SNOW-948463 Removed error information for PUT command for GCP #801

merged 1 commit into from
Oct 27, 2023

Conversation

sfc-gh-dstempniak
Copy link
Collaborator

@sfc-gh-dstempniak sfc-gh-dstempniak commented Oct 25, 2023 •
edited
Loading

Description

SNOW-948463 Removed error information for PUT command for GCP

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #801 (1d14ab6) into master (64b638c) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##           master     #801   +/-   ##
=======================================
  Coverage   83.45%   83.45%           
=======================================
  Files          89       89           
  Lines        9065     9067    +2     
  Branches      826      826           
=======================================
+ Hits         7565     7567    +2     
  Misses       1274     1274           
  Partials      226      226
Files Coverage Δ
...leTransfer/StorageClient/SFSnowflakeAzureClient.cs 100.00% <100.00%> (ø)
...ata/Core/FileTransfer/StorageClient/SFGCSClient.cs 94.06% <75.00%> (-0.28%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-dstempniak sfc-gh-dstempniak marked this pull request as ready for review October 25, 2023 16:35
@sfc-gh-dstempniak sfc-gh-dstempniak requested a review from a team as a code owner October 25, 2023 16:35
@sfc-gh-dstempniak sfc-gh-dstempniak merged commit 635b214 into master Oct 27, 2023
19 of 20 checks passed
@sfc-gh-dstempniak sfc-gh-dstempniak deleted the SNOW-948463 branch October 27, 2023 12:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-knozderko sfc-gh-knozderko sfc-gh-knozderko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-dstempniak @sfc-gh-knozderko